rluvaton commented on PR #23345: URL: https://github.com/apache/datafusion/pull/23345#issuecomment-4914327357
> Hi @rluvaton -- I am sort of lost on this PR -- it seems like it adds some non trivial complexity but I can't quite seem what benchmarks are made faster. > > is it really tpch_sort (aka [(earlier comment)](https://github.com/apache/datafusion/pull/23345#issuecomment-4896979725)) ? Yes, I also created dedicated micro benchmarks: - https://github.com/apache/datafusion/pull/23346 > Is there any way to make this PR (and the logic) simpler? tried to simplify it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
