kosiew commented on code in PR #23223:
URL: https://github.com/apache/datafusion/pull/23223#discussion_r3544773666
##########
datafusion/functions/src/strings.rs:
##########
@@ -969,30 +937,70 @@ pub(crate) struct StringViewWriter<'a> {
/// `None` while the row fits inline; becomes `Some(start)` (offset of
/// the row's first byte in `in_progress`) at first spill.
spill_cursor: Option<usize>,
+ error: Option<DataFusionError>,
builder: &'a mut StringViewArrayBuilder,
}
+impl StringViewWriter<'_> {
+ #[inline]
Review Comment:
added
[comment](https://github.com/apache/datafusion/pull/23223/commits/cefb00011c457e13003806c8321bb1f797fb1706)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
