ratmice commented on PR #23387: URL: https://github.com/apache/datafusion/pull/23387#issuecomment-4919528945
So the only thing I'm a bit uncertain/hesitant about (I'm really not all that familiar with `clap`), is whether this will work for anyone who wants to extend the arguments using `#[command(flatten)]`, adding their own command line options, but reuse the standard ones. I kind of assume that use case will need additional changes with something like `CliSession::from_clap_args(clap_args: entry_point::Args)`, but uncertain and hesitate to implement it without any trying to actually do that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
