jayzhan211 commented on code in PR #11753:
URL: https://github.com/apache/datafusion/pull/11753#discussion_r1708159337
##########
datafusion/functions/src/regex/regexplike.rs:
##########
@@ -75,13 +75,8 @@ impl ScalarUDFImpl for RegexpLikeFunc {
use DataType::*;
Ok(match &arg_types[0] {
- LargeUtf8 | Utf8 => Boolean,
Null => Null,
- other => {
- return plan_err!(
- "The regexp_like function can only accept strings. Got
{other}"
- );
- }
+ _ => Boolean,
Review Comment:
> I was thinking the type coercion already handles, in theory, ensuring the
correct types are passed in, so the extra check was not necessary. I can put
back the explicit check if you prefer
I think you are right, we don't need another type check in `return_type`.
> it is very counter intuitive to return a Boolean because that case
shouldn't exists.
The type check should be handled in signature before `return_type`. We could
improve docs about how the types and length check are handled in UDF/UDAF
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
