kosiew commented on code in PR #23343: URL: https://github.com/apache/datafusion/pull/23343#discussion_r3549096679
########## datafusion/physical-plan/src/aggregates/group_values/multi_group_by/primitive.rs: ########## @@ -83,6 +83,9 @@ where Review Comment: Nice work here. One small test suggestion: it might be worth adding a regression test where some `equal_to_results` bits are already set to `false`, and the matching `lhs_rows` or `rhs_rows` entries would panic if they were read. That would make it really clear that `vectorized_equal_to` skips those rows as intended, instead of only preserving the existing false bits by coincidence. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
