alamb commented on PR #23369: URL: https://github.com/apache/datafusion/pull/23369#issuecomment-4924752348
> Basically no regression, and it seems resolve the pushdown_filters regression, but Adaptive predicate evaluation should be better. This seems like a very nice find (a simple heuristic) @zhuqi-lucas -- would you be willing to make a new PR with just this change? I think we should consider doing it. The heuristic might also want to take into account data type (e.g. projecting string columns might count more than projecting an int column) I would like to run some more tests to see that it works across other query benchmarks, but I think we should do it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
