adriangb commented on code in PR #23130:
URL: https://github.com/apache/datafusion/pull/23130#discussion_r3552171267
##########
datafusion/physical-expr/src/scalar_subquery.rs:
##########
@@ -59,19 +59,6 @@ impl ScalarSubqueryExpr {
}
}
- pub fn data_type(&self) -> &DataType {
- &self.data_type
- }
-
- pub fn nullable(&self) -> bool {
- self.nullable
- }
-
- /// Returns the index of this subquery in the shared results container.
- pub fn index(&self) -> SubqueryIndex {
- self.index
- }
Review Comment:
```suggestion
#[deprecated(
since = "55.0.0",
note = "was only used for proto serialization, which no longer needs
it; use `return_field` for type/nullability. It will be removed in 61.0.0 or 6
months after 55.0.0 is released, whichever is longer."
)]
pub fn data_type(&self) -> &DataType {
&self.data_type
}
#[deprecated(
since = "55.0.0",
note = "was only used for protger needs it; use `return_field`
fortype/nullability. It will be removed in 61.0.0 or 6 months after 55.0.0 is
released, whichever is longer."
)]
pub fn nullable(&self) -> bool {
self.nullable
}
/// Returns the index of this subquery in the shared results container.
#[deprecated(
since = "55.0.0",
note = "was only used for protger needs it. It will be removed
in61.0.0 or 6 months after 55.0.0 is released, whichever is longer."
)]
pub fn index(&self) -> SubqueryInd
self.index
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
