andygrove opened a new pull request, #4872:
URL: https://github.com/apache/datafusion-comet/pull/4872

   ## Which issue does this PR close?
   
   N/A. This is a small lint fix to unblock CI.
   
   ## Rationale for this change
   
   A newer Rust/clippy version now flags a `redundant_reference` lint in the 
`fs-hdfs` crate:
   
   ```
   error: redundant reference in `info!` argument
      --> fs-hdfs/src/hdfs.rs:103:54
   103 |     info!("Connecting to Namenode ({})", &namenode_uri);
       |       help: remove the redundant `&`: `namenode_uri`
   ```
   
   The `fs-hdfs` crate is a workspace member listed in `members` but not 
`default-members`, so local builds that use the default members do not lint it. 
CI runs `cargo clippy --all-targets --workspace -- -D warnings`, which includes 
`fs-hdfs`, so the lint fails the `rust-test` job on the current toolchain.
   
   ## What changes are included in this PR?
   
   Remove the redundant `&` on the `namenode_uri` argument in the `info!` call 
in `native/fs-hdfs/src/hdfs.rs`.
   
   ## How are these changes tested?
   
   `cargo clippy -p datafusion-comet-fs-hdfs3 --all-targets -- -D warnings` 
passes with this change and fails without it. Covered by the existing 
`rust-test` CI job.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to