samuelcolvin commented on code in PR #11454:
URL: https://github.com/apache/datafusion/pull/11454#discussion_r1709238159
##########
datafusion/expr/src/columnar_value.rs:
##########
@@ -183,6 +185,43 @@ impl ColumnarValue {
Ok(args)
}
+ fn _format_interval_string_value(&self, str_val: &String) ->
Option<String> {
+ let start_idx = if str_val.starts_with('-') { 1 } else { 0 };
+
+ // only incase of simple input that all char is a number.
+ if str_val[start_idx..].chars().all(|c| c.is_ascii_digit()) {
+ return Some(format!("{} second", str_val));
+ }
+ None
+ }
+
+ fn _kernels_cast_with_option(
Review Comment:
maybe useful to add a docstring here explaining why this method is necessary
/ what it does.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
