github-actions[bot] commented on PR #22362: URL: https://github.com/apache/datafusion/pull/22362#issuecomment-4932348095
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion-proto v54.0.0 (current) error: running cargo-doc on crate 'datafusion-proto' failed with output: ----- Compiling proc-macro2 v1.0.106 Compiling unicode-ident v1.0.24 Compiling quote v1.0.46 Compiling libc v0.2.186 Checking cfg-if v1.0.4 Checking memchr v2.8.3 Compiling autocfg v1.5.1 Compiling libm v0.2.16 Compiling num-traits v0.2.19 Compiling syn v2.0.118 Checking bytes v1.12.1 Compiling zerocopy v0.8.54 Compiling serde_core v1.0.228 Checking allocator-api2 v0.2.21 Checking foldhash v0.2.0 Checking once_cell v1.21.4 Checking itoa v1.0.18 Checking equivalent v1.0.2 Compiling getrandom v0.3.4 Checking hashbrown v0.17.1 Compiling zmij v1.0.21 Compiling serde_json v1.0.150 Checking indexmap v2.14.0 Checking num-integer v0.1.46 Compiling version_check v0.9.5 Checking siphasher v1.0.3 Checking iana-time-zone v0.1.65 Checking chrono v0.4.45 Checking phf_shared v0.12.1 Compiling ahash v0.8.12 Compiling jobserver v0.1.35 Checking num-bigint v0.4.8 Checking stable_deref_trait v1.2.1 Compiling shlex v2.0.1 Compiling find-msvc-tools v0.1.9 Compiling chrono-tz v0.10.4 Compiling cc v1.2.66 Compiling synstructure v0.13.2 Checking arrow-schema v59.1.0 Checking phf v0.12.1 Compiling pkg-config v0.3.33 Checking num-complex v0.4.6 Checking pin-project-lite v0.2.17 Checking lexical-util v1.0.7 Compiling zstd-sys v2.0.16+zstd.1.5.7 Compiling zerocopy-derive v0.8.54 Compiling zerofrom-derive v0.1.7 Compiling yoke-derive v0.8.2 Compiling zerovec-derive v0.11.3 Checking zerofrom v0.1.8 Checking yoke v0.8.3 Compiling displaydoc v0.2.6 Checking futures-core v0.3.32 Checking zerovec v0.11.6 Checking writeable v0.6.3 Checking litemap v0.8.2 Checking smallvec v1.15.2 Checking futures-sink v0.3.32 Checking zerotrie v0.2.4 Checking tinystr v0.8.3 Checking icu_locale_core v2.2.0 Checking potential_utf v0.1.5 Compiling icu_normalizer_data v2.2.0 Checking utf8_iter v1.0.4 Compiling icu_properties_data v2.2.0 Checking icu_collections v2.2.0 Checking icu_provider v2.2.0 Compiling semver v1.0.28 Compiling zstd-safe v7.2.4 Compiling rustc_version v0.4.1 Checking futures-channel v0.3.32 Checking lexical-parse-integer v1.0.6 Checking lexical-write-integer v1.0.6 Compiling futures-macro v0.3.32 Compiling tokio-macros v2.7.0 Checking half v2.7.1 Checking futures-task v0.3.32 Checking futures-io v0.3.32 Checking slab v0.4.12 Checking bitflags v2.13.0 Checking arrow-buffer v59.1.0 Compiling parking_lot_core v0.9.12 Checking base64 v0.22.1 Checking futures-util v0.3.32 Checking tokio v1.52.3 Checking arrow-data v59.1.0 Checking arrow-array v59.1.0 Checking lexical-write-float v1.0.6 Checking lexical-parse-float v1.0.6 Compiling flatbuffers v25.12.19 Checking icu_properties v2.2.0 Checking icu_normalizer v2.2.0 Checking arrow-select v59.1.0 Checking aho-corasick v1.1.4 Checking unicode-width v0.2.2 Checking ryu v1.0.23 Compiling crc32fast v1.5.0 Checking scopeguard v1.2.0 Checking regex-syntax v0.8.11 Compiling getrandom v0.4.3 Checking unicode-segmentation v1.13.3 Checking arrow-ord v59.1.0 Checking comfy-table v7.2.2 Checking lock_api v0.4.14 Checking idna_adapter v1.2.2 Checking lexical-core v1.0.6 Checking atoi v2.0.0 Checking adler2 v2.0.1 Compiling snap v1.1.1 Checking percent-encoding v2.3.2 Compiling thiserror v2.0.18 Checking simd-adler32 v0.3.9 Checking twox-hash v2.1.2 Checking alloc-no-stdlib v2.0.4 Checking either v1.16.0 Checking alloc-stdlib v0.2.4 Checking lz4_flex v0.13.1 Checking miniz_oxide v0.8.9 Checking regex-automata v0.4.15 Checking form_urlencoded v1.2.2 Checking arrow-cast v59.1.0 Checking idna v1.1.0 Checking futures-executor v0.3.32 Compiling tracing-attributes v0.1.31 Compiling thiserror-impl v2.0.18 Checking regex v1.13.0 Checking tracing-core v0.1.36 Checking csv-core v0.1.13 Checking simdutf8 v0.1.5 Compiling paste v1.0.15 Checking same-file v1.0.6 Checking zlib-rs v0.6.6 Checking walkdir v2.5.0 Checking csv v1.4.0 Checking tracing v0.1.44 Checking futures v0.3.32 Checking url v2.5.8 Checking itertools v0.14.0 Checking brotli-decompressor v5.0.3 Checking flate2 v1.1.9 Checking parking_lot v0.12.5 Compiling async-trait v0.1.89 Checking http v1.4.2 Checking humantime v2.4.0 Compiling serde v1.0.228 Compiling anyhow v1.0.103 Checking object_store v0.13.2 Checking brotli v8.0.4 Checking arrow-csv v59.1.0 Checking arrow-json v59.1.0 Checking arrow-string v59.1.0 Checking uuid v1.23.4 Checking arrow-row v59.1.0 Checking arrow-arith v59.1.0 Compiling serde_derive v1.0.228 Checking log v0.4.33 Compiling seq-macro v0.3.6 Checking itertools v0.15.0 Compiling prost-derive v0.14.4 Compiling pin-project-internal v1.1.13 Checking pin-project v1.1.13 Checking pbjson v0.9.0 Checking ppv-lite86 v0.2.21 Checking rand_core v0.9.5 Compiling crossbeam-utils v0.8.22 Checking prost v0.14.4 Compiling rustix v1.1.4 Checking rand_chacha v0.9.0 Checking datafusion-doc v54.0.0 (/home/runner/work/datafusion/datafusion/datafusion/doc) Checking linux-raw-sys v0.12.1 Checking rand v0.9.4 Checking tokio-util v0.7.18 Checking fastrand v2.4.1 Checking foldhash v0.1.5 Checking hashbrown v0.14.5 Checking hashbrown v0.15.5 Checking fixedbitset v0.5.7 Checking zstd v0.13.3 Checking dashmap v6.2.1 Checking arrow-ipc v59.1.0 Checking petgraph v0.8.3 Compiling datafusion-macros v54.0.0 (/home/runner/work/datafusion/datafusion/datafusion/macros) Checking tempfile v3.27.0 Checking hex v0.4.3 Checking datafusion-common-runtime v54.0.0 (/home/runner/work/datafusion/datafusion/datafusion/common-runtime) Checking glob v0.3.3 Compiling liblzma-sys v0.4.7 Checking crc-catalog v2.5.0 Compiling heck v0.5.0 Checking libbz2-rs-sys v0.2.5 Checking arrow v59.1.0 Checking parquet v59.1.0 Checking bzip2 v0.6.1 Compiling strum_macros v0.28.0 Checking crc v3.4.0 Checking tokio-stream v0.1.18 Checking datafusion-common v54.0.0 (/home/runner/work/datafusion/datafusion/datafusion/common) Checking liblzma v0.4.7 Checking arrow-avro v59.1.0 Checking datafusion-proto-common v54.0.0 (/home/runner/work/datafusion/datafusion/datafusion/proto-common) Checking datafusion-expr-common v54.0.0 (/home/runner/work/datafusion/datafusion/datafusion/expr-common) Checking datafusion-proto-models v54.0.0 (/home/runner/work/datafusion/datafusion/datafusion/proto-models) Checking datafusion-physical-expr-common v54.0.0 (/home/runner/work/datafusion/datafusion/datafusion/physical-expr-common) Checking datafusion-functions-window-common v54.0.0 (/home/runner/work/datafusion/datafusion/datafusion/functions-window-common) Checking datafusion-functions-aggregate-common v54.0.0 (/home/runner/work/datafusion/datafusion/datafusion/functions-aggregate-common) Checking datafusion-expr v54.0.0 (/home/runner/work/datafusion/datafusion/datafusion/expr) Checking datafusion-execution v54.0.0 (/home/runner/work/datafusion/datafusion/datafusion/execution) Checking datafusion-physical-expr v54.0.0 (/home/runner/work/datafusion/datafusion/datafusion/physical-expr) Checking datafusion-functions v54.0.0 (/home/runner/work/datafusion/datafusion/datafusion/functions) Checking datafusion-physical-plan v54.0.0 (/home/runner/work/datafusion/datafusion/datafusion/physical-plan) Checking datafusion-physical-expr-adapter v54.0.0 (/home/runner/work/datafusion/datafusion/datafusion/physical-expr-adapter) Checking datafusion-session v54.0.0 (/home/runner/work/datafusion/datafusion/datafusion/session) Checking datafusion-datasource v54.0.0 (/home/runner/work/datafusion/datafusion/datafusion/datasource) Checking datafusion-catalog v54.0.0 (/home/runner/work/datafusion/datafusion/datafusion/catalog) Checking datafusion-pruning v54.0.0 (/home/runner/work/datafusion/datafusion/datafusion/pruning) Checking datafusion-datasource-json v54.0.0 (/home/runner/work/datafusion/datafusion/datafusion/datasource-json) Checking datafusion-datasource-avro v54.0.0 (/home/runner/work/datafusion/datafusion/datafusion/datasource-avro) Checking datafusion-datasource-csv v54.0.0 (/home/runner/work/datafusion/datafusion/datafusion/datasource-csv) Checking datafusion-datasource-parquet v54.0.0 (/home/runner/work/datafusion/datafusion/datafusion/datasource-parquet) Checking datafusion-datasource-arrow v54.0.0 (/home/runner/work/datafusion/datafusion/datafusion/datasource-arrow) Checking datafusion-catalog-listing v54.0.0 (/home/runner/work/datafusion/datafusion/datafusion/catalog-listing) Checking datafusion-functions-table v54.0.0 (/home/runner/work/datafusion/datafusion/datafusion/functions-table) Documenting datafusion-proto v54.0.0 (/home/runner/work/datafusion/datafusion/datafusion/proto) error[E0404]: expected trait, found struct `HigherOrderUDF` --> /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:3953:25 | 3953 | ) -> Result<Arc<dyn HigherOrderUDF>> { | ^^^^^^^^^^^^^^ not a trait error[E0404]: expected trait, found struct `HigherOrderUDF` --> /home/runner/work/datafusion/datafusion/datafusion/proto/src/physical_plan/mod.rs:3961:21 | 3961 | _node: &dyn HigherOrderUDF, | ^^^^^^^^^^^^^^ not a trait For more information about this error, try `rustc --explain E0404`. error: could not document `datafusion-proto` ----- error: failed to build rustdoc for crate datafusion-proto v54.0.0 note: this is usually due to a compilation error in the crate, and is unlikely to be a bug in cargo-semver-checks note: the following command can be used to reproduce the error: cargo new --lib example && cd example && echo '[workspace]' >> Cargo.toml && cargo add --path /home/runner/work/datafusion/datafusion/datafusion/proto --features avro,datafusion-datasource-avro,datafusion-datasource-parquet,default,json,parquet,serde_json && cargo check && cargo doc Building datafusion-proto-models v54.0.0 (current) Built [ 19.314s] (current) Parsing datafusion-proto-models v54.0.0 (current) Parsed [ 0.103s] (current) Building datafusion-proto-models v54.0.0 (baseline) Built [ 18.883s] (baseline) Parsing datafusion-proto-models v54.0.0 (baseline) Parsed [ 0.104s] (baseline) Checking datafusion-proto-models v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 2.002s] 223 checks: 222 pass, 1 fail, 0 warn, 30 skip --- failure enum_variant_added: enum variant added on exhaustive enum --- Description: A publicly-visible enum without #[non_exhaustive] has a new variant. ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/enum_variant_added.ron Failed in: variant ExprType:HigherOrderUdfExpr in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:806 variant ExprType:Lambda in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:808 variant ExprType:LambdaVariable in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:810 variant ExprType:HigherOrderUdfExpr in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:806 variant ExprType:Lambda in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:808 variant ExprType:LambdaVariable in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:810 variant ExprType:HigherOrderUdf in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:1565 variant ExprType:Lambda in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:1567 variant ExprType:LambdaVariable in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:1569 variant ExprType:HigherOrderUdf in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:1565 variant ExprType:Lambda in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:1567 variant ExprType:LambdaVariable in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:1569 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 41.778s] datafusion-proto-models error: aborting due to failure to build rustdoc for crate datafusion-proto v54.0.0 ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
