andygrove commented on code in PR #1982:
URL:
https://github.com/apache/datafusion-ballista/pull/1982#discussion_r3564386734
##########
ballista/scheduler/src/state/execution_graph.rs:
##########
@@ -240,6 +240,16 @@ pub trait ExecutionGraph: Debug {
/// Exposes executions stages and stage id's
fn stages(&self) -> &HashMap<usize, ExecutionStage>;
+ /// Stage ids of all non-final (intermediate) stages — those whose
+ /// `output_links` is non-empty. The final stage(s) are excluded.
+ fn intermediate_stage_ids(&self) -> Vec<u32> {
Review Comment:
You are correct. The current PR does no harm under AQE (and we run TPC-H in
CI with AQE enabled). I filed a follow-on issue to implement this for AQE.
https://github.com/apache/datafusion-ballista/issues/1996
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
