zhuqi-lucas commented on PR #23420: URL: https://github.com/apache/datafusion/pull/23420#issuecomment-4949973765
Updated: found a real correctness bug — the heuristic-declined branch was mutating source.predicate and simultaneously telling the parent nothing was pushed, which desynced DynamicFilter tracking for shared expressions (surfaced as +46 extra rows on TPCH Q20). Fixed and rerunning both benchmarks; expecting the TPCH numbers to improve substantially. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
