alamb commented on PR #23414: URL: https://github.com/apache/datafusion/pull/23414#issuecomment-4950847097
> One minor clarification: xtask itself does not require installing any additional tools. It is more like a Cargo builtin feature (or convention): https://github.com/matklad/cargo-xtask I think you need to do ```shell cargo install cargo-xtask ``` I am also somewhat worried about taking on a new (admittedly dev only) dependency. For example, I took a look at https://github.com/matklad/cargo-xtask and it was last updated 9 months ago and it doesn't have an obvious long term maintenance model (e.g. bugs,. etc) beyond someone's personal project > I still think xtask will be easier to use and maintain in the long term. The existing leaf scripts already contain additional logic rather than just invoking plain commands. Personally, I find Rust/xtask easier to work with: Rust is DataFusion's native language, and it provides more structure than shell scripts. I agree that shell scripts are not great for complex logic. What I was wondering is can we avoid complicated shell scripts by simplifying that logic (like does it need to follow all the dependency checks that the current CI does?) rather than finding a some system (like `xtask`) to help manage that complxity -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
