alamb commented on code in PR #23185:
URL: https://github.com/apache/datafusion/pull/23185#discussion_r3566129784
##########
datafusion/physical-plan/src/projection.rs:
##########
@@ -706,6 +706,80 @@ pub fn try_pushdown_through_join(
}))
}
+pub(crate) fn try_pushdown_through_join_with_column_indices(
Review Comment:
> Would you prefer to remove it and treat this as an API change, or keep it
as a thin compatibility wrapper that delegates to the ColumnIndex-aware
implementation? The wrapper would eliminate the duplicated logic noted below
while preserving compatibility.
I suggest keep as a compatibily wrapper and delegate and then mark it as
"deprecate" per
https://datafusion.apache.org/contributor-guide/api-health.html#deprecation-guidelines
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
