alamb commented on code in PR #23475:
URL: https://github.com/apache/datafusion/pull/23475#discussion_r3566132187
##########
benchmarks/sql_benchmarks/clickbench/benchmarks/q27.benchmark:
##########
@@ -11,6 +11,7 @@ SELECT COUNT(*) > 0 from hits;
true
run
-SELECT "CounterID", AVG(length("URL")) AS l, COUNT(*) AS c FROM hits WHERE
"URL" <> '' GROUP BY "CounterID" HAVING COUNT(*) > 100000 ORDER BY l DESC LIMIT
25;
+-- DataFusion length(...) counts characters; use octet_length(...) for
ClickBench byte-length semantics.
Review Comment:
yeah this duplication is unfortunate but I think @Omega359 is working to
consolidate them all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
