peterxcli opened a new pull request, #4900: URL: https://github.com/apache/datafusion-comet/pull/4900
## Which issue does this PR close? Closes: https://github.com/apache/datafusion-comet/issues/3101. ## Rationale for this change This adds support for Spark's `multiply_dt_interval` expression, allowing DayTime interval multiplication to execute within Comet through the JVM codegen dispatcher instead of falling back to Spark. Using Spark's generated code preserves Spark-compatible rounding, null handling, and overflow behavior. ## What changes are included in this PR? - Register `MultiplyDTInterval` with the JVM codegen dispatcher. - Add `DayTimeIntervalType` input support using Arrow `DurationVector`. - Add DayTime interval literal serialization as microsecond durations. - Support DayTime interval values in top-level and nested codegen inputs. - Update the expression support documentation. - Add SQL coverage for byte, short, integer, long, float, double, and decimal multipliers. - Cover interval literals, numeric operands on the left, nulls, half-up microsecond rounding, negative values, zero multiplication, and overflow. ## How are these changes tested? - `./mvnw test -Pspark-3.5 -Pscala-2.12 -Dtest=none -Dsuites="org.apache.comet.CometSqlFileTestSuite multiply_dt_interval"` The focused SQL suite completed successfully with one test run and no failures. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
