kosiew commented on code in PR #22714:
URL: https://github.com/apache/datafusion/pull/22714#discussion_r3571296065
##########
datafusion/sqllogictest/src/engines/datafusion_engine/normalize.rs:
##########
@@ -271,6 +271,8 @@ pub fn convert_schema_to_types(columns: &Fields) ->
Vec<DFColumnType> {
DataType::Float16
| DataType::Float32
| DataType::Float64
+ | DataType::Decimal32(_, _)
Review Comment:
```
# example of passing test (DFColumnType::Float makes SLT comparisons
approximate for these decimal types) which should fail
+query R
+select arrow_cast('1.2300', 'Decimal32(9, 4)');
+----
+1.23
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
