Rich-T-kid commented on code in PR #23523:
URL: https://github.com/apache/datafusion/pull/23523#discussion_r3573068220
##########
datafusion/physical-plan/src/aggregates/group_values/row.rs:
##########
@@ -267,7 +267,15 @@ impl GroupValues for GroupValuesRows {
}
}
-fn dictionary_encode_if_necessary(
+/// Re-apply dictionary / run-end encoding to `array` so it matches `expected`.
+///
+/// Arrow's [`RowConverter`] decodes dictionary and run-end-encoded values to
+/// their plain value type on the way out, so any group-value array produced
Review Comment:
> Arrow's [`RowConverter`] decodes dictionary and run-end-encoded values to
their plain value type on the way out
nit: RowConverter decodes dictionarys/REE on their way in [since it occurs
on](https://arrow.apache.org/rust/arrow_row/struct.RowConverter.html#method.append)`RowConverter::append()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
