clflushopt commented on PR #23488: URL: https://github.com/apache/datafusion/pull/23488#issuecomment-4963892292
> Direction and implementation look good. Standard `OuterReference` encoding matches #20439, and local Substrait suite passed. > > PR description starts with unrelated `SingleDistinctToGroupBy` content. Could you remove that copied section? Wow that threw me off for a bit I was looking at a existing PRs to understand the PR template I should follow and I must have accidently copy-paste it into this one. Fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
