gabotechs commented on PR #23542:
URL: https://github.com/apache/datafusion/pull/23542#issuecomment-4969800436

   🤔 As main does not have the benchmarks, the bot cannot perform the 
comparison. I run the benches myself and can replicate locally, so it's all 
good 👍 
   
   ```
   Benchmarking date_trunc_minute_1000: Warming up forBenchmarking 
date_trunc_minute_1000: Collecting 100date_trunc_minute_1000  time:   [694.47 
ns 699.78 ns 704.89 ns]
                           change: [−6.8407% −6.2167% −5.5712%] (p = 0.00 < 
0.05)
                           Performance has improved.
   
   Benchmarking date_trunc_month_second_1000: Warming Benchmarking 
date_trunc_month_second_1000: Collecting 100 samples in estimated 5.0138 s 
(500k iteratioBenchmarking date_trunc_month_second_1000: 
Analyzindate_trunc_month_second_1000
                           time:   [9.8196 µs 9.8537 µs 9.8944 µs]
                           change: [−68.766% −66.918% −65.032%] (p = 0.00 < 
0.05)
                           Performance has improved.
   
   Benchmarking date_trunc_week_nanos_1000: Warming upBenchmarking 
date_trunc_week_nanos_1000: Collecting 100 samples in estimated 5.0005 s (869k 
iterationsdate_trunc_week_nanos_1000
                           time:   [5.7474 µs 5.7796 µs 5.8186 µs]
                           change: [−78.538% −78.362% −78.193%] (p = 0.00 < 
0.05)
                           Performance has improved.
   
   Benchmarking date_trunc_month_nanos_1000: Warming uBenchmarking 
date_trunc_month_nanos_1000: Collecting 100 samples in estimated 5.0166 s (465k 
iterationdate_trunc_month_nanos_1000
                           time:   [10.598 µs 10.634 µs 10.676 µs]
                           change: [−49.751% −49.509% −49.275%] (p = 0.00 < 
0.05)
                           Performance has improved.
   
   date_trunc_quarter_nanos_1000
                           time:   [16.065 µs 16.086 µs 16.111 µs]
                           change: [−32.441% −32.229% −32.017%] (p = 0.00 < 
0.05)
                           Performance has improved.
   
   date_trunc_year_nanos_1000
                           time:   [13.355 µs 13.404 µs 13.462 µs]
                           change: [−40.818% −40.571% −40.316%] (p = 0.00 < 
0.05)
                           Performance has improved.
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to