Rich-T-kid commented on code in PR #23523:
URL: https://github.com/apache/datafusion/pull/23523#discussion_r3579603208
##########
datafusion/physical-plan/src/aggregates/group_values/multi_group_by/mod.rs:
##########
@@ -923,6 +925,15 @@ macro_rules! instantiate_primitive {
/// builder for. The `group_column_supported_type_matches_make_group_column`
/// test below pins this biconditional.
fn group_column_supported_type(data_type: &DataType) -> bool {
+ // Nested types (Struct / List / LargeList / FixedSizeList, recursively)
have
+ // no type-specialized `GroupColumn`; they are handled by the generic
+ // row-backed fallback in `make_group_column` whenever arrow's row format
can
+ // encode them. Gate the fallback to nested types so intentionally-excluded
+ // scalar types (e.g. Float16, Decimal256) stay on `GroupValuesRows` and
the
+ // `group_column_supported_type` ⇔ `make_group_column` invariant holds.
+ if data_type.is_nested() {
+ return RowsGroupColumn::supports_type(data_type);
+ }
Review Comment:
makes sense to me 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
