HairstonE commented on code in PR #22132: URL: https://github.com/apache/datafusion/pull/22132#discussion_r3583337823
########## datafusion/sqllogictest/test_files/optimizer_group_by_constant.slt: ########## @@ -60,26 +60,42 @@ FROM test_table t group by 1, 2, 3 ---- logical_plan Review Comment: These all have the new filter, but their outputs are unchanged because the filter passes whenever count > 0. The empty input tests are in aggregate.slt. Those tests on main would return 1 row of NULL, these changes return 0 rows. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
