Jefffrey commented on PR #23586:
URL: https://github.com/apache/datafusion/pull/23586#issuecomment-4977028167
running locally 🤔
```diff
datafusion (perf-pad-preallocate)$ cargo bench --bench pad
Compiling datafusion-functions v54.0.0
(/Users/jeffrey/Code/datafusion/datafusion/functions)
Finished `bench` profile [optimized] target(s) in 53.38s
Running benches/pad.rs
(/Users/jeffrey/.cargo_target_cache/release/deps/pad-2f089923d141bc24)
Gnuplot not found, using plotters backend
lpad size=1024/lpad utf8 [size=1024, str_len=5, target=20]
time: [12.004 µs 12.025 µs 12.048 µs]
change: [−1.4729% −1.0920% −0.7246%] (p = 0.00 <
0.05)
Change within noise threshold.
lpad size=1024/lpad stringview [size=1024, str_len=5, target=20]
time: [11.285 µs 11.298 µs 11.314 µs]
+ change: [−1.7233% −1.5672% −1.3975%] (p = 0.00 <
0.05)
Performance has improved.
Found 1 outliers among 10 measurements (10.00%)
1 (10.00%) high mild
lpad size=1024/lpad utf8 [size=1024, str_len=20, target=50]
time: [10.732 µs 10.745 µs 10.758 µs]
change: [−0.4523% −0.2387% −0.0325%] (p = 0.05 >
0.05)
No change in performance detected.
lpad size=1024/lpad stringview [size=1024, str_len=20, target=50]
time: [11.067 µs 11.089 µs 11.110 µs]
+ change: [−5.1783% −4.9185% −4.6458%] (p = 0.00 <
0.05)
Performance has improved.
lpad size=1024/lpad utf8 unicode [size=1024, target=20]
time: [24.486 µs 24.529 µs 24.579 µs]
change: [−1.0974% −0.8344% −0.5539%] (p = 0.00 <
0.05)
Change within noise threshold.
Found 1 outliers among 10 measurements (10.00%)
1 (10.00%) high mild
lpad size=1024/lpad stringview unicode [size=1024, target=20]
time: [23.717 µs 23.755 µs 23.792 µs]
+ change: [−7.5437% −7.2754% −7.0047%] (p = 0.00 <
0.05)
Performance has improved.
lpad size=1024/lpad utf8 scalar [size=1024, str_len=5, target=20, fill='x']
time: [8.3927 µs 8.4038 µs 8.4142 µs]
+ change: [−2.4699% −2.1815% −1.9562%] (p = 0.00 <
0.05)
Performance has improved.
lpad size=1024/lpad stringview scalar [size=1024, str_len=5, target=20,
fill='x']
time: [9.8403 µs 9.9081 µs 9.9943 µs]
+ change: [−5.2462% −4.0179% −2.7820%] (p = 0.00 <
0.05)
Performance has improved.
Found 1 outliers among 10 measurements (10.00%)
1 (10.00%) high mild
lpad size=1024/lpad utf8 scalar unicode [size=1024, str_len=5, target=20,
fill='é']
time: [10.919 µs 10.960 µs 11.012 µs]
+ change: [−2.0479% −1.6018% −1.0937%] (p = 0.00 <
0.05)
Performance has improved.
Found 1 outliers among 10 measurements (10.00%)
1 (10.00%) high severe
lpad size=1024/lpad utf8 scalar truncate [size=1024, str_len=20, target=5,
fill='é']
time: [8.6206 µs 8.6510 µs 8.6810 µs]
+ change: [−2.3786% −1.9546% −1.5204%] (p = 0.00 <
0.05)
Performance has improved.
lpad size=4096/lpad utf8 [size=4096, str_len=5, target=20]
time: [50.040 µs 50.191 µs 50.361 µs]
change: [−1.9546% −1.3620% −0.7866%] (p = 0.00 <
0.05)
Change within noise threshold.
Found 2 outliers among 10 measurements (20.00%)
2 (20.00%) high mild
lpad size=4096/lpad stringview [size=4096, str_len=5, target=20]
time: [44.867 µs 45.098 µs 45.393 µs]
+ change: [−4.1224% −3.3313% −2.5541%] (p = 0.00 <
0.05)
Performance has improved.
Found 1 outliers among 10 measurements (10.00%)
1 (10.00%) high mild
lpad size=4096/lpad utf8 [size=4096, str_len=20, target=50]
time: [42.346 µs 42.555 µs 42.824 µs]
change: [−0.6360% +0.3920% +1.3606%] (p = 0.48 >
0.05)
No change in performance detected.
Found 2 outliers among 10 measurements (20.00%)
1 (10.00%) high mild
1 (10.00%) high severe
lpad size=4096/lpad stringview [size=4096, str_len=20, target=50]
time: [44.801 µs 45.342 µs 45.872 µs]
+ change: [−6.7400% −4.1348% −1.7028%] (p = 0.01 <
0.05)
Performance has improved.
lpad size=4096/lpad utf8 unicode [size=4096, target=20]
time: [97.595 µs 97.748 µs 97.905 µs]
+ change: [−3.0691% −2.6122% −2.2359%] (p = 0.00 <
0.05)
Performance has improved.
lpad size=4096/lpad stringview unicode [size=4096, target=20]
time: [99.429 µs 99.609 µs 99.791 µs]
change: [+0.2509% +0.5439% +0.8081%] (p = 0.00 <
0.05)
Change within noise threshold.
lpad size=4096/lpad utf8 scalar [size=4096, str_len=5, target=20, fill='x']
time: [32.852 µs 32.987 µs 33.136 µs]
change: [−1.5198% −1.1692% −0.7345%] (p = 0.00 <
0.05)
Change within noise threshold.
lpad size=4096/lpad stringview scalar [size=4096, str_len=5, target=20,
fill='x']
time: [39.621 µs 39.880 µs 40.224 µs]
+ change: [−4.9508% −3.7632% −2.3827%] (p = 0.00 <
0.05)
Performance has improved.
Found 1 outliers among 10 measurements (10.00%)
1 (10.00%) high mild
lpad size=4096/lpad utf8 scalar unicode [size=4096, str_len=5, target=20,
fill='é']
time: [48.059 µs 48.478 µs 48.995 µs]
change: [−0.1663% +1.7006% +3.6558%] (p = 0.11 >
0.05)
No change in performance detected.
Found 1 outliers among 10 measurements (10.00%)
1 (10.00%) high mild
lpad size=4096/lpad utf8 scalar truncate [size=4096, str_len=20, target=5,
fill='é']
time: [33.890 µs 33.966 µs 34.050 µs]
change: [−1.6891% −1.3195% −0.9609%] (p = 0.00 <
0.05)
Change within noise threshold.
Found 1 outliers among 10 measurements (10.00%)
1 (10.00%) high mild
rpad size=1024/rpad utf8 [size=1024, str_len=5, target=20]
time: [11.997 µs 12.022 µs 12.059 µs]
+ change: [−2.8990% −2.5727% −2.1797%] (p = 0.00 <
0.05)
Performance has improved.
Found 1 outliers among 10 measurements (10.00%)
1 (10.00%) high severe
rpad size=1024/rpad stringview [size=1024, str_len=5, target=20]
time: [11.587 µs 11.611 µs 11.636 µs]
- change: [+2.0510% +2.4664% +2.8646%] (p = 0.00 <
0.05)
Performance has regressed.
rpad size=1024/rpad utf8 [size=1024, str_len=20, target=50]
time: [10.905 µs 10.925 µs 10.947 µs]
+ change: [−2.9546% −2.6782% −2.4071%] (p = 0.00 <
0.05)
Performance has improved.
rpad size=1024/rpad stringview [size=1024, str_len=20, target=50]
time: [11.519 µs 11.563 µs 11.605 µs]
change: [−0.8420% −0.2823% +0.2300%] (p = 0.32 >
0.05)
No change in performance detected.
rpad size=1024/rpad utf8 unicode [size=1024, target=20]
time: [23.396 µs 23.451 µs 23.522 µs]
+ change: [−2.1529% −1.7824% −1.3578%] (p = 0.00 <
0.05)
Performance has improved.
Found 1 outliers among 10 measurements (10.00%)
1 (10.00%) high severe
rpad size=1024/rpad stringview unicode [size=1024, target=20]
time: [24.576 µs 24.616 µs 24.655 µs]
- change: [+1.9827% +2.5195% +2.9850%] (p = 0.00 <
0.05)
Performance has regressed.
rpad size=1024/rpad utf8 scalar [size=1024, str_len=5, target=20, fill='x']
time: [9.4030 µs 9.4210 µs 9.4395 µs]
- change: [+10.332% +10.647% +10.937%] (p = 0.00 <
0.05)
Performance has regressed.
rpad size=1024/rpad stringview scalar [size=1024, str_len=5, target=20,
fill='x']
time: [9.5579 µs 9.6091 µs 9.6757 µs]
+ change: [−2.8800% −2.0180% −1.2005%] (p = 0.00 <
0.05)
Performance has improved.
Found 1 outliers among 10 measurements (10.00%)
1 (10.00%) high mild
rpad size=1024/rpad utf8 scalar unicode [size=1024, str_len=5, target=20,
fill='é']
time: [11.001 µs 11.034 µs 11.076 µs]
change: [−1.5820% −0.7324% −0.0868%] (p = 0.08 >
0.05)
No change in performance detected.
Found 2 outliers among 10 measurements (20.00%)
2 (20.00%) high severe
rpad size=1024/rpad utf8 scalar truncate [size=1024, str_len=20, target=5,
fill='é']
time: [8.7616 µs 8.7892 µs 8.8224 µs]
change: [−0.2353% +0.2652% +0.7746%] (p = 0.34 >
0.05)
No change in performance detected.
Found 1 outliers among 10 measurements (10.00%)
1 (10.00%) high mild
rpad size=4096/rpad utf8 [size=4096, str_len=5, target=20]
time: [49.810 µs 49.991 µs 50.236 µs]
+ change: [−4.2701% −3.5716% −2.8561%] (p = 0.00 <
0.05)
Performance has improved.
Found 3 outliers among 10 measurements (30.00%)
1 (10.00%) low mild
1 (10.00%) high mild
1 (10.00%) high severe
rpad size=4096/rpad stringview [size=4096, str_len=5, target=20]
time: [46.610 µs 46.793 µs 47.043 µs]
- change: [+1.0865% +1.6177% +2.2518%] (p = 0.00 <
0.05)
Performance has regressed.
Found 1 outliers among 10 measurements (10.00%)
1 (10.00%) high severe
rpad size=4096/rpad utf8 [size=4096, str_len=20, target=50]
time: [43.381 µs 43.697 µs 44.044 µs]
+ change: [−3.3156% −2.1610% −1.0205%] (p = 0.00 <
0.05)
Performance has improved.
rpad size=4096/rpad stringview [size=4096, str_len=20, target=50]
time: [44.916 µs 45.270 µs 45.697 µs]
+ change: [−4.3002% −2.9718% −1.5472%] (p = 0.00 <
0.05)
Performance has improved.
Found 2 outliers among 10 measurements (20.00%)
2 (20.00%) high mild
rpad size=4096/rpad utf8 unicode [size=4096, target=20]
time: [97.440 µs 97.628 µs 97.805 µs]
change: [−0.3706% −0.1170% +0.1607%] (p = 0.43 >
0.05)
No change in performance detected.
rpad size=4096/rpad stringview unicode [size=4096, target=20]
time: [100.96 µs 101.05 µs 101.14 µs]
change: [+0.9846% +1.2233% +1.4580%] (p = 0.00 <
0.05)
Change within noise threshold.
rpad size=4096/rpad utf8 scalar [size=4096, str_len=5, target=20, fill='x']
time: [36.871 µs 36.930 µs 36.986 µs]
- change: [+11.018% +11.280% +11.526%] (p = 0.00 <
0.05)
Performance has regressed.
rpad size=4096/rpad stringview scalar [size=4096, str_len=5, target=20,
fill='x']
time: [37.843 µs 38.050 µs 38.298 µs]
change: [−1.3528% −0.5895% +0.2055%] (p = 0.20 >
0.05)
No change in performance detected.
Found 1 outliers among 10 measurements (10.00%)
1 (10.00%) high mild
rpad size=4096/rpad utf8 scalar unicode [size=4096, str_len=5, target=20,
fill='é']
time: [44.222 µs 44.390 µs 44.592 µs]
change: [−1.0349% −0.3982% +0.2564%] (p = 0.27 >
0.05)
No change in performance detected.
Found 1 outliers among 10 measurements (10.00%)
1 (10.00%) high mild
rpad size=4096/rpad utf8 scalar truncate [size=4096, str_len=20, target=5,
fill='é']
time: [34.120 µs 34.232 µs 34.341 µs]
change: [−0.6915% −0.1185% +0.3951%] (p = 0.69 >
0.05)
No change in performance detected.
Found 3 outliers among 10 measurements (30.00%)
2 (20.00%) low mild
1 (10.00%) high mild
```
cant seem to get as good results
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
