eejbyfeldt commented on code in PR #793:
URL: https://github.com/apache/datafusion-comet/pull/793#discussion_r1710955171
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -2348,6 +2348,27 @@ object QueryPlanSerde extends Logging with
ShimQueryPlanSerde with CometExprShim
.build()
}
+ // datafusion's make_array only supports nullable element types
+ case array @ CreateArray(children, _) if array.dataType.containsNull =>
+ val childExprs = children.map(exprToProto(_, inputs, binding))
+ val dataType = serializeDataType(array.dataType)
Review Comment:
I am also still learning more on Datafusion. But my understanding aligns
with this comment you made:
> I'm not sure how it could even be updated with the way it currently works,
since ScalarUDFImpl.return_type just has DataType and not Field to know whether
the elements are nullable or not.
My understanding is that an API breakage would be needed in Datafusion to
make it possible to implement make_array with correct nullability for the
element.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
