iffyio commented on code in PR #2404:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2404#discussion_r3594708381
##########
src/parser/mod.rs:
##########
@@ -18870,6 +18870,14 @@ impl<'a> Parser<'a> {
let duplicate_treatment = self.parse_duplicate_treatment()?;
let args = self.parse_comma_separated(Parser::parse_function_args)?;
+ // Inline aggregate filter: `AGG(expr WHERE cond [ORDER BY ..])`,
popularized by
+ // GoogleSQL. Precedes ORDER BY / LIMIT / HAVING; equivalent to the
standard
+ // `AGG(expr) FILTER (WHERE cond)`. Accepted for all dialects: `WHERE`
is a reserved
+ // keyword that cannot begin a function argument, so the syntax is
unambiguous.
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
