vismaytiwari commented on PR #23279: URL: https://github.com/apache/datafusion/pull/23279#issuecomment-4993844303
Done — pushed. The result now keeps the input time's unit instead of widening to `Time64(ns)`: the coercion arm carries the time operand's type through as the result type, and `apply_time_interval` dispatches per unit (a small generic `wrap_time_interval<T>`) so the interval is applied at the time's resolution. Finer-than-unit precision truncates, so `time(s) + interval '1 nanosecond'` is a no-op — same as `timestamp(s) + interval '1 nanosecond'`. Added per-unit `arrow_typeof` assertions and the truncation cases to the slt; `cargo test` (coercion + physical-expr), the datetime slt, fmt and clippy `--all-targets -D warnings` are all green locally. Also refreshed the 55.0.0 upgrade note (it had said the result was always ns). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
