github-actions[bot] commented on PR #23649: URL: https://github.com/apache/datafusion/pull/23649#issuecomment-4995629670
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion v54.0.0 (current) Built [ 103.691s] (current) Parsing datafusion v54.0.0 (current) Parsed [ 0.036s] (current) Building datafusion v54.0.0 (baseline) Built [ 105.316s] (baseline) Parsing datafusion v54.0.0 (baseline) Parsed [ 0.035s] (baseline) Checking datafusion v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.645s] 223 checks: 221 pass, 2 fail, 0 warn, 30 skip --- failure function_parameter_count_changed: pub fn parameter count changed --- Description: A publicly-visible function now takes a different number of parameters. ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/function_parameter_count_changed.ron Failed in: datafusion::physical_planner::create_window_expr_with_name now takes 5 parameters instead of 4, in /home/runner/work/datafusion/datafusion/datafusion/core/src/physical_planner.rs:2523 datafusion::physical_planner::create_window_expr now takes 4 parameters instead of 3, in /home/runner/work/datafusion/datafusion/datafusion/core/src/physical_planner.rs:2604 --- failure trait_method_parameter_count_changed: pub trait method parameter count changed --- Description: A trait method now takes a different number of parameters. ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-item-signature impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/trait_method_parameter_count_changed.ron Failed in: PhysicalPlanner::create_physical_expr now takes 4 instead of 3 parameters, in file /home/runner/work/datafusion/datafusion/datafusion/core/src/physical_planner.rs:147 ExtensionPlanner::plan_extension now takes 6 instead of 5 parameters, in file /home/runner/work/datafusion/datafusion/datafusion/core/src/physical_planner.rs:174 ExtensionPlanner::plan_table_scan now takes 4 instead of 3 parameters, in file /home/runner/work/datafusion/datafusion/datafusion/core/src/physical_planner.rs:251 Summary semver requires new major version: 2 major and 0 minor checks failed Finished [ 211.216s] datafusion Building datafusion-catalog v54.0.0 (current) Built [ 39.821s] (current) Parsing datafusion-catalog v54.0.0 (current) Parsed [ 0.025s] (current) Building datafusion-catalog v54.0.0 (baseline) Built [ 41.226s] (baseline) Parsing datafusion-catalog v54.0.0 (baseline) Parsed [ 0.027s] (baseline) Checking datafusion-catalog v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.165s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 82.267s] datafusion-catalog Building datafusion-catalog-listing v54.0.0 (current) Built [ 47.806s] (current) Parsing datafusion-catalog-listing v54.0.0 (current) Parsed [ 0.012s] (current) Building datafusion-catalog-listing v54.0.0 (baseline) Built [ 46.379s] (baseline) Parsing datafusion-catalog-listing v54.0.0 (baseline) Parsed [ 0.012s] (baseline) Checking datafusion-catalog-listing v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.089s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 95.491s] datafusion-catalog-listing Building datafusion-datasource v54.0.0 (current) Built [ 37.872s] (current) Parsing datafusion-datasource v54.0.0 (current) Parsed [ 0.031s] (current) Building datafusion-datasource v54.0.0 (baseline) Built [ 37.388s] (baseline) Parsing datafusion-datasource v54.0.0 (baseline) Parsed [ 0.033s] (baseline) Checking datafusion-datasource v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.244s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 76.696s] datafusion-datasource Building datafusion-expr v54.0.0 (current) Built [ 26.673s] (current) Parsing datafusion-expr v54.0.0 (current) Parsed [ 0.075s] (current) Building datafusion-expr v54.0.0 (baseline) Built [ 26.668s] (baseline) Parsing datafusion-expr v54.0.0 (baseline) Parsed [ 0.077s] (baseline) Checking datafusion-expr v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 1.223s] 223 checks: 222 pass, 1 fail, 0 warn, 30 skip --- failure struct_pub_field_missing: pub struct's pub field removed or renamed --- Description: A publicly-visible struct has at least one public field that is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/struct_pub_field_missing.ron Failed in: field subquery_indexes of struct ExecutionProps, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/194a357a000890b6004c42f42887c7512d11be8d/datafusion/expr/src/execution_props.rs:69 field subquery_results of struct ExecutionProps, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/194a357a000890b6004c42f42887c7512d11be8d/datafusion/expr/src/execution_props.rs:72 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 55.751s] datafusion-expr Building datafusion-functions-nested v54.0.0 (current) Built [ 35.637s] (current) Parsing datafusion-functions-nested v54.0.0 (current) Parsed [ 0.039s] (current) Building datafusion-functions-nested v54.0.0 (baseline) Built [ 37.415s] (baseline) Parsing datafusion-functions-nested v54.0.0 (baseline) Parsed [ 0.043s] (baseline) Checking datafusion-functions-nested v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.221s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 74.333s] datafusion-functions-nested Building datafusion-optimizer v54.0.0 (current) Built [ 28.084s] (current) Parsing datafusion-optimizer v54.0.0 (current) Parsed [ 0.031s] (current) Building datafusion-optimizer v54.0.0 (baseline) Built [ 27.845s] (baseline) Parsing datafusion-optimizer v54.0.0 (baseline) Parsed [ 0.035s] (baseline) Checking datafusion-optimizer v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.184s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 57.342s] datafusion-optimizer Building datafusion-physical-expr v54.0.0 (current) Built [ 29.139s] (current) Parsing datafusion-physical-expr v54.0.0 (current) Parsed [ 0.049s] (current) Building datafusion-physical-expr v54.0.0 (baseline) Built [ 30.127s] (baseline) Parsing datafusion-physical-expr v54.0.0 (baseline) Parsed [ 0.050s] (baseline) Checking datafusion-physical-expr v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.328s] 223 checks: 221 pass, 2 fail, 0 warn, 30 skip --- failure function_parameter_count_changed: pub fn parameter count changed --- Description: A publicly-visible function now takes a different number of parameters. ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/function_parameter_count_changed.ron Failed in: datafusion_physical_expr::create_physical_sort_exprs now takes 4 parameters instead of 3, in /home/runner/work/datafusion/datafusion/datafusion/physical-expr/src/physical_expr.rs:219 datafusion_physical_expr::create_physical_sort_expr now takes 4 parameters instead of 3, in /home/runner/work/datafusion/datafusion/datafusion/physical-expr/src/physical_expr.rs:202 datafusion_physical_expr::planner::create_physical_exprs now takes 4 parameters instead of 3, in /home/runner/work/datafusion/datafusion/datafusion/physical-expr/src/planner.rs:704 datafusion_physical_expr::create_physical_exprs now takes 4 parameters instead of 3, in /home/runner/work/datafusion/datafusion/datafusion/physical-expr/src/planner.rs:704 datafusion_physical_expr::create_physical_partitioning now takes 4 parameters instead of 3, in /home/runner/work/datafusion/datafusion/datafusion/physical-expr/src/physical_expr.rs:236 datafusion_physical_expr::planner::create_physical_expr now takes 4 parameters instead of 3, in /home/runner/work/datafusion/datafusion/datafusion/physical-expr/src/planner.rs:126 datafusion_physical_expr::create_physical_expr now takes 4 parameters instead of 3, in /home/runner/work/datafusion/datafusion/datafusion/physical-expr/src/planner.rs:126 --- failure method_parameter_count_changed: pub method parameter count changed --- Description: A publicly-visible method now takes a different number of parameters, not counting the receiver (self) parameter. ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/method_parameter_count_changed.ron Failed in: datafusion_physical_expr::aggregate::LoweredAggregateBuilder::new takes 4 parameters in /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/194a357a000890b6004c42f42887c7512d11be8d/datafusion/physical-expr/src/aggregate.rs:434, but now takes 5 parameters in /home/runner/work/datafusion/datafusion/datafusion/physical-expr/src/aggregate.rs:439 Summary semver requires new major version: 2 major and 0 minor checks failed Finished [ 60.497s] datafusion-physical-expr ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
