alamb commented on PR #23646: URL: https://github.com/apache/datafusion/pull/23646#issuecomment-4995850374
> This PR looks very reasonable. I noticed that this is very similar to the `ByteGroupValueBuilder` implementation. I think it would be worth it to try and see if we can modify `ByteGroupValueBuilder` to support similar optimizations such as batched writes. besides that `vectorized/equal_to` and the other trait methods are 1-1. If `ByteGroupValueBuilder` cant be expanded on to include fixed size binary without extensive branching that hurts readability thats also fine. This sounds like a good thing to explore in a follow on / parallel PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
