alamb commented on code in PR #23637:
URL: https://github.com/apache/datafusion/pull/23637#discussion_r3598457031


##########
benchmarks/README.md:
##########
@@ -507,23 +507,35 @@ The runner applies two ClickBench-specific setup steps 
automatically:
   runner enables the parquet `binary_as_string` option so those columns
   are read as strings.
 
-If you set up ClickBench manually through SQL, use the same `EventDate`
-view pattern:
+If you set up ClickBench manually through SQL, register the single-file
+dataset as follows:
 
 ```sql
 CREATE EXTERNAL TABLE hits_raw
 STORED AS PARQUET
 LOCATION 'benchmarks/data/hits.parquet';
+```
+
+For the partitioned dataset, register the directory and enable

Review Comment:
   I tested this locally and it works great
   
   ```sql
   DataFusion CLI v54.0.0
   > CREATE EXTERNAL TABLE hits_raw
   STORED AS PARQUET
   LOCATION 'benchmarks/data/hits_partitioned'
   OPTIONS ('binary_as_string' 'true');
   0 row(s) fetched.
   Elapsed 0.060 seconds.
   
   > CREATE VIEW hits AS
   SELECT * EXCEPT ("EventDate"),
          CAST(CAST("EventDate" AS INTEGER) AS DATE) AS "EventDate"
   FROM hits_raw;
   0 row(s) fetched.
   Elapsed 0.010 seconds.
   
   > SELECT COUNT(*) FROM hits WHERE "AdvEngineID" <> 0;
   
   +----------+
   | count(*) |
   +----------+
   | 630500   |
   +----------+
   1 row(s) fetched.
   Elapsed 0.030 seconds.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to