andygrove commented on code in PR #4948:
URL: https://github.com/apache/datafusion-comet/pull/4948#discussion_r3599059985
##########
spark/src/main/scala/org/apache/comet/serde/predicates.scala:
##########
@@ -104,6 +110,8 @@ object CometOr extends CometExpressionSerde[Or] {
}
object CometEqualTo extends CometExpressionSerde[EqualTo] {
+ override def getSupportLevel(expr: EqualTo): SupportLevel =
+ ComparisonUtils.collationSupportLevel(expr.left, expr.right)
Review Comment:
Could you add/update tests for predicates to demonstrate the fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
