github-actions[bot] commented on PR #23467: URL: https://github.com/apache/datafusion/pull/23467#issuecomment-5000259269
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion v54.0.0 (current) Built [ 105.959s] (current) Parsing datafusion v54.0.0 (current) Parsed [ 0.035s] (current) Building datafusion v54.0.0 (baseline) Built [ 103.385s] (baseline) Parsing datafusion v54.0.0 (baseline) Parsed [ 0.034s] (baseline) Checking datafusion v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.580s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 212.738s] datafusion Building datafusion-datasource v54.0.0 (current) Built [ 37.693s] (current) Parsing datafusion-datasource v54.0.0 (current) Parsed [ 0.031s] (current) Building datafusion-datasource v54.0.0 (baseline) Built [ 36.863s] (baseline) Parsing datafusion-datasource v54.0.0 (baseline) Parsed [ 0.032s] (baseline) Checking datafusion-datasource v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.241s] 223 checks: 221 pass, 2 fail, 0 warn, 30 skip --- failure trait_method_missing: pub trait method removed or renamed --- Description: A trait method is no longer callable, and may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-item-signature impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/trait_method_missing.ron Failed in: method with_batch_size of trait FileSource, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/d4406bcd5aa1525203a285dec9206551d290fabd/datafusion/datasource/src/file.rs:107 --- failure trait_method_parameter_count_changed: pub trait method parameter count changed --- Description: A trait method now takes a different number of parameters. ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-item-signature impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/trait_method_parameter_count_changed.ron Failed in: FileSource::create_file_opener now takes 2 instead of 3 parameters, in file /home/runner/work/datafusion/datafusion/datafusion/datasource/src/file.rs:132 FileSource::create_morselizer now takes 2 instead of 3 parameters, in file /home/runner/work/datafusion/datafusion/datafusion/datasource/src/file.rs:145 Summary semver requires new major version: 2 major and 0 minor checks failed Finished [ 76.489s] datafusion-datasource Building datafusion-datasource-arrow v54.0.0 (current) Built [ 37.497s] (current) Parsing datafusion-datasource-arrow v54.0.0 (current) Parsed [ 0.012s] (current) Building datafusion-datasource-arrow v54.0.0 (baseline) Built [ 37.566s] (baseline) Parsing datafusion-datasource-arrow v54.0.0 (baseline) Parsed [ 0.012s] (baseline) Checking datafusion-datasource-arrow v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.074s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 76.504s] datafusion-datasource-arrow Building datafusion-datasource-avro v54.0.0 (current) Built [ 39.070s] (current) Parsing datafusion-datasource-avro v54.0.0 (current) Parsed [ 0.009s] (current) Building datafusion-datasource-avro v54.0.0 (baseline) Built [ 39.201s] (baseline) Parsing datafusion-datasource-avro v54.0.0 (baseline) Parsed [ 0.010s] (baseline) Checking datafusion-datasource-avro v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.071s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 79.661s] datafusion-datasource-avro Building datafusion-datasource-csv v54.0.0 (current) Built [ 38.121s] (current) Parsing datafusion-datasource-csv v54.0.0 (current) Parsed [ 0.010s] (current) Building datafusion-datasource-csv v54.0.0 (baseline) Built [ 38.171s] (baseline) Parsing datafusion-datasource-csv v54.0.0 (baseline) Parsed [ 0.011s] (baseline) Checking datafusion-datasource-csv v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.096s] 223 checks: 222 pass, 1 fail, 0 warn, 30 skip --- failure method_parameter_count_changed: pub method parameter count changed --- Description: A publicly-visible method now takes a different number of parameters, not counting the receiver (self) parameter. ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/method_parameter_count_changed.ron Failed in: datafusion_datasource_csv::source::CsvOpener::new takes 3 parameters in /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/d4406bcd5aa1525203a285dec9206551d290fabd/datafusion/datasource-csv/src/source.rs:222, but now takes 4 parameters in /home/runner/work/datafusion/datafusion/datafusion/datasource-csv/src/source.rs:217 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 77.440s] datafusion-datasource-csv Building datafusion-datasource-json v54.0.0 (current) Built [ 37.920s] (current) Parsing datafusion-datasource-json v54.0.0 (current) Parsed [ 0.012s] (current) Building datafusion-datasource-json v54.0.0 (baseline) Built [ 37.714s] (baseline) Parsing datafusion-datasource-json v54.0.0 (baseline) Parsed [ 0.013s] (baseline) Checking datafusion-datasource-json v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.094s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 76.998s] datafusion-datasource-json Building datafusion-datasource-parquet v54.0.0 (current) Built [ 43.651s] (current) Parsing datafusion-datasource-parquet v54.0.0 (current) Parsed [ 0.029s] (current) Building datafusion-datasource-parquet v54.0.0 (baseline) Built [ 43.677s] (baseline) Parsing datafusion-datasource-parquet v54.0.0 (baseline) Parsed [ 0.030s] (baseline) Checking datafusion-datasource-parquet v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.150s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 89.025s] datafusion-datasource-parquet ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
