mhilton opened a new pull request, #11908:
URL: https://github.com/apache/datafusion/pull/11908
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #11905.
## Rationale for this change
There doesn't appear to be an existing way to create a NULL valued arrow
Array from a `ScalarValue::Dictionary`.
## What changes are included in this PR?
Update the way ScalarValue::Dictionary values are turned into arrays such
that:
scalar_value.is_null() == scalar_value.to_array()?.is_null(0)
Previously the dictionary would be created with a valid key entry pointing
to a NULL value.
https://arrow.apache.org/docs/format/Columnar.html#dictionary-encoded-layout
suggests that this does not constitute a NULL entry.
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
Yes
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
Yes, it is possible someone, somewhere, is relying on the existing
behaviour, although I can't think of a use myself. I consider that the least
surprising behaviour is that the following holds true for all possible
`ScalarValue`s:
scalar_value.is_null() == scalar_value.to_array()?.is_null(0)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
