dharanad commented on code in PR #11712:
URL: https://github.com/apache/datafusion/pull/11712#discussion_r1711831090


##########
datafusion/functions-nested/src/map.rs:
##########
@@ -161,7 +174,19 @@ impl ScalarUDFImpl for MapFunc {
         &self.signature
     }
 
-    fn return_type(&self, arg_types: &[DataType]) -> 
datafusion_common::Result<DataType> {
+    fn return_type(
+        &self,
+        _arg_types: &[DataType],
+    ) -> datafusion_common::Result<DataType> {
+        internal_err!("map: return_type called instead of 
return_type_from_exprs")
+    }
+
+    fn return_type_from_exprs(
+        &self,
+        _args: &[Expr],
+        _schema: &dyn ExprSchema,
+        arg_types: &[DataType],
+    ) -> datafusion_common::Result<DataType> {

Review Comment:
   I reverted it back. I is misunderstood the requirement.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to