zhuqi-lucas commented on PR #186: URL: https://github.com/apache/datafusion-site/pull/186#issuecomment-5013889473
Thanks a lot for the deep pass @alamb — this reads much better than what I put up. Structure changes (buffering + decoder-loop moved to appendices, Related Work at the end, cleaner Exact/Inexact split) are all improvements. Pushed one small commit (1666952) with three narrow tweaks: - **Row-Level Early Stopping paragraph**: reworded so `#22450`'s contribution is described as "keeps the threshold up-to-date at row-group boundaries" rather than "adds projection-column skip". The projection-column skip itself lives in arrow-rs `RowFilter` — `#22450` just makes it fire more often. - **Conclusion**: replaced "In DataFusion 54, we implemented …" with "Over the last few DataFusion releases we implemented …". `#22450` merged 2026-06-22, after `54.0.0` was tagged, so it will ship in a later release. - **Decision-tree figure alt-text**: `try_pushdown_sort` → `PushdownSort` to match the struct name used throughout the surrounding prose. Happy to add per-query `sort_tpch` numbers as you suggested — I have them locally, will add in a follow-up. And +1 on planning publish for Monday July 20th. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
