avantgardnerio commented on PR #2038: URL: https://github.com/apache/datafusion-ballista/pull/2038#issuecomment-5017263348
> LGTM. Thanks @avantgardnerio! I only tested with the default setting for the new config Thanks @andygrove ! I'm going to go ahead and merge. I'll address the 1 nit in a follow up PR tomorrow. I think we can live with max_partitions_per_task=1 for now. Other settings improve some queries and hurt others, but at least it's up to users to tweak for their workloads. Merging this will unblock me to submit a series of followups to make more small incremental improvements. I really appreciate all the reviews & feedback @milenkovicm @Dandandan & @andygrove ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
