u70b3 commented on issue #22216:
URL: https://github.com/apache/datafusion/issues/22216#issuecomment-5019650819

   Verified on current main (1e589287c): this no longer reproduces. The issue's 
repro query now plans successfully instead of panicking with `attempt to 
multiply with overflow`:
   
   ```sql
   EXPLAIN SELECT date_bin(
     INTERVAL '1 microsecond',
     arrow_cast(0, 'Time64(Microsecond)'),
     arrow_cast(9223372036854775807, 'Time64(Microsecond)')
   );
   ```
   
   The Time64 scaling path now uses checked arithmetic 
(`checked_scale_to_nanos`, from the #22610 date_bin overflow-fix series). The 
twin issue #22212 (same root cause, extreme value as the *source* argument) is 
fixed as well. Suggest closing both.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to