adriangb commented on PR #23701: URL: https://github.com/apache/datafusion/pull/23701#issuecomment-5025551587
@zhuqi-lucas I wonder how this compares against previous proposals of tracking selectivity & compute time and disabling dynamic filters if they are not pulling their weight? Either at the expression level (https://github.com/apache/datafusion/pull/22234) or at the scan level (https://github.com/apache/datafusion/pull/22237). It seems that this PR is now both disabling the membership pushdown by default (`enable_hash_join_dynamic_membership_filter = false`) and changing the shape of the filter. I think we should evaluate that in separate changes. And neither of them seem like they need to be stacked on https://github.com/apache/datafusion/pull/22384? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
