Phoenix500526 commented on code in PR #23710:
URL: https://github.com/apache/datafusion/pull/23710#discussion_r3618950867
##########
datafusion/proto/src/physical_plan/mod.rs:
##########
@@ -775,14 +775,12 @@ pub trait PhysicalPlanNodeExt: Sized {
PhysicalPlanType::ArrowScan(scan) => {
self.try_into_arrow_scan_physical_plan(scan, ctx,
proto_converter)
}
- PhysicalPlanType::CoalesceBatches(coalesce_batches) => self
- .try_into_coalesce_batches_physical_plan(
- coalesce_batches,
- ctx,
- proto_converter,
- ),
- PhysicalPlanType::Merge(merge) => {
- self.try_into_merge_physical_plan(merge, ctx, proto_converter)
+ #[expect(deprecated)]
Review Comment:
`try_from_proto` itself is not deprecated. `CoalesceBatchesExec` is the
deprecated item, and referring to it in `CoalesceBatchesExec::try_from_proto`
triggers the deprecation lint. The attribute is scoped to this match arm to
allow decoding the legacy protobuf variant.
FYI：https://github.com/apache/datafusion/pull/19622
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
