Jefffrey commented on code in PR #23714:
URL: https://github.com/apache/datafusion/pull/23714#discussion_r3619284855
##########
datafusion/functions-aggregate/src/approx_distinct.rs:
##########
@@ -1078,6 +1080,66 @@ mod tests {
assert_count_numerical_acc_and_group_acc::<Decimal256Type>(decimal_256, 6);
}
+ #[test]
+ fn union_support_hll_acc_and_group_acc() {
Review Comment:
what if we add more rows here:
https://github.com/apache/datafusion/blob/3a2bc0a0a5673386ab2238b545dbedb82ce6b92b/datafusion/sqllogictest/src/test_context.rs#L560-L594
then can use in slts like here
https://github.com/apache/datafusion/blob/3a2bc0a0a5673386ab2238b545dbedb82ce6b92b/datafusion/sqllogictest/test_files/union_function.slt#L18-L30
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
