Phoenix500526 opened a new pull request, #23752:
URL: https://github.com/apache/datafusion/pull/23752
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
- Closes #23498.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
`DataSinkExec` serialization currently depends on central downcasting in
`datafusion-proto`. This prevents individual `DataSink` implementations from
owning their protobuf serialization logic.
Additionally, `FileSinkConfig` is owned by `datafusion-datasource`, while its
protobuf conversion was implemented in `datafusion-proto`. Moving the
conversion alongside the type allows file sink implementations to reuse it
without depending on the central proto crate.
This provides the foundation for migrating CSV, JSON, and Parquet sink
serialization in follow-up work.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
- Add a feature-gated `DataSink::try_to_proto` hook with a default
implementation returning `None`.
- Make `DataSinkExec::try_to_proto` encode its input and required ordering
before delegating to the underlying sink.
- Retain the existing central serializer as a compatibility fallback for
sinks that have not implemented the hook.
- Move `FileSinkConfig` protobuf encoding and decoding into
`datafusion-datasource`.
- Keep the existing `TryFromProto` implementations as compatibility
delegates.
- Add a helper for decoding a sink's required output ordering.
- Preserve the existing protobuf wire representation.
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
Yes.
- Added a custom `DataSink` test verifying that `DataSinkExec` delegates
serialization with the encoded input and required ordering.
- Added coverage verifying that the direct `FileSinkConfig` conversion and
compatibility APIs produce the same protobuf data.
- Existing file sink round-trip tests continue to pass.
- Ran `cargo fmt --all`.
- Ran Clippy for all targets and features with warnings denied.
- Ran the required extended workspace test suite.
- Ran all 210 `datafusion-proto` integration tests.
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
No. This is an internal serialization refactor. Existing protobuf data and
the compatibility serialization path remain supported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
