lyne7-sc commented on code in PR #23743: URL: https://github.com/apache/datafusion/pull/23743#discussion_r3622931165
########## datafusion/sqllogictest/test_files/string/string_query.slt.part: ########## @@ -645,10 +645,10 @@ drop table test_lowercase; query IIII SELECT - ASCII(ascii_1) as c1, - ASCII(ascii_2) as c2, - ASCII(unicode_1) as c3, - ASCII(unicode_2) as c4 + arrow_cast(ASCII(ascii_1), 'Int32') as c1, Review Comment: Yes, this keeps the existing value test unchanged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
