Rachelint commented on issue #11931: URL: https://github.com/apache/datafusion/issues/11931#issuecomment-2282594861
> Is the plan to manage group values and states in two different kinds of blocks, or a unified block? > > There are so many good optimizations in the aggregation code now, they make the implementation a bit hard to understand, I was thinking managing group values + states in a single block could also be a good cleanup Plan to make them two kinds of blocks, because `group values` is the inner struct in `GroupValues`, and `states` is the one in different `GroupAccumulator`, seems hard to manage them in a same place. The design is similar as #7065 , but introduce it into `GroupValues`, not only `GroupAccumulator`s. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
