comphead commented on code in PR #4989:
URL: https://github.com/apache/datafusion-comet/pull/4989#discussion_r3624717910
##########
native/proto/src/proto/operator.proto:
##########
@@ -340,6 +340,9 @@ message ShuffleWriter {
// to absorb DataFusion-vs-Spark type drift. Empty when the child is a
placeholder Scan;
// that path already has a cast point upstream.
repeated SparkStructField expected_output_schema = 9;
+ // Maximum number of bytes that the writer buffers in memory before spilling
to disk.
+ // Zero means no limit, in which case spilling is driven only by memory pool
pressure.
+ int64 max_buffer_bytes = 10;
Review Comment:
```suggestion
uint64 max_buffer_bytes = 10;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
