nuno-faria commented on code in PR #23758:
URL: https://github.com/apache/datafusion/pull/23758#discussion_r3625087646
##########
datafusion/sqllogictest/test_files/expr.slt:
##########
@@ -1654,6 +1678,30 @@ SELECT sha384(NULL);
----
NULL
+# sha384 string and binary array inputs
+query BBBBBB
+SELECT
+ sha384(column1) = sha384('tom'),
+ sha384(arrow_cast(column1, 'LargeUtf8')) = sha384('tom'),
+ sha384(arrow_cast(column1, 'Utf8View')) = sha384('tom'),
+ sha384(arrow_cast(column1, 'Binary')) = sha384('tom'),
+ sha384(arrow_cast(column1, 'LargeBinary')) = sha384('tom'),
+ sha384(arrow_cast(column1, 'BinaryView')) = sha384('tom')
+FROM (VALUES ('tom'), (NULL)) AS t(column1);
Review Comment:
```suggestion
FROM (VALUES ('tom'), (NULL), ('mot')) AS t(column1);
```
##########
datafusion/sqllogictest/test_files/expr.slt:
##########
@@ -1594,6 +1594,30 @@ SELECT sha224(NULL);
----
NULL
+# sha224 string and binary array inputs
+query BBBBBB
+SELECT
+ sha224(column1) = sha224('tom'),
+ sha224(arrow_cast(column1, 'LargeUtf8')) = sha224('tom'),
+ sha224(arrow_cast(column1, 'Utf8View')) = sha224('tom'),
+ sha224(arrow_cast(column1, 'Binary')) = sha224('tom'),
+ sha224(arrow_cast(column1, 'LargeBinary')) = sha224('tom'),
+ sha224(arrow_cast(column1, 'BinaryView')) = sha224('tom')
+FROM (VALUES ('tom'), (NULL)) AS t(column1);
Review Comment:
```suggestion
FROM (VALUES ('tom'), (NULL), ('mot')) AS t(column1);
```
##########
datafusion/sqllogictest/test_files/expr.slt:
##########
@@ -1684,6 +1732,30 @@ SELECT sha512(NULL);
----
NULL
+# sha512 string and binary array inputs
+query BBBBBB
+SELECT
+ sha512(column1) = sha512('tom'),
+ sha512(arrow_cast(column1, 'LargeUtf8')) = sha512('tom'),
+ sha512(arrow_cast(column1, 'Utf8View')) = sha512('tom'),
+ sha512(arrow_cast(column1, 'Binary')) = sha512('tom'),
+ sha512(arrow_cast(column1, 'LargeBinary')) = sha512('tom'),
+ sha512(arrow_cast(column1, 'BinaryView')) = sha512('tom')
+FROM (VALUES ('tom'), (NULL)) AS t(column1);
Review Comment:
```suggestion
FROM (VALUES ('tom'), (NULL), ('mot')) AS t(column1);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
