dariocurr commented on PR #23797: URL: https://github.com/apache/datafusion/pull/23797#issuecomment-5045514511
Re the cargo-semver-checks note above: this is an expected, intentional minor breaking change. `exec_from_repl` gained a required `history_file: Option<&Path>` parameter so the interactive shell's history location can be configured (this PR's whole purpose); the only in-tree caller besides `main.rs` is `datafusion-cli/examples/cli-session-context.rs`, which has been updated accordingly. Per the [API health policy](https://datafusion.apache.org/contributor-guide/api-health.html), could a committer add the `api change` label to this PR? I don't have push access to add it myself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
