github-actions[bot] commented on PR #23807: URL: https://github.com/apache/datafusion/pull/23807#issuecomment-5048011578
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion v54.1.0 (current) Built [ 110.292s] (current) Parsing datafusion v54.1.0 (current) Parsed [ 0.034s] (current) Building datafusion v54.1.0 (baseline) Built [ 107.568s] (baseline) Parsing datafusion v54.1.0 (baseline) Parsed [ 0.036s] (baseline) Checking datafusion v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.693s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 220.777s] datafusion Building datafusion-expr v54.1.0 (current) Built [ 28.294s] (current) Parsing datafusion-expr v54.1.0 (current) Parsed [ 0.076s] (current) Building datafusion-expr v54.1.0 (baseline) Built [ 28.321s] (baseline) Parsing datafusion-expr v54.1.0 (baseline) Parsed [ 0.082s] (baseline) Checking datafusion-expr v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 1.343s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 59.732s] datafusion-expr Building datafusion-expr-common v54.1.0 (current) Built [ 19.607s] (current) Parsing datafusion-expr-common v54.1.0 (current) Parsed [ 0.018s] (current) Building datafusion-expr-common v54.1.0 (baseline) Built [ 19.409s] (baseline) Parsing datafusion-expr-common v54.1.0 (baseline) Parsed [ 0.018s] (baseline) Checking datafusion-expr-common v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.208s] 223 checks: 222 pass, 1 fail, 0 warn, 30 skip --- failure constructible_struct_adds_field: externally-constructible struct adds field --- Description: A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.49.0/src/lints/constructible_struct_adds_field.ron Failed in: field ExprProperties.strictly_order_preserving in /home/runner/work/datafusion/datafusion/datafusion/expr-common/src/sort_properties.rs:199 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 41.074s] datafusion-expr-common Building datafusion-ffi v54.1.0 (current) Built [ 63.217s] (current) Parsing datafusion-ffi v54.1.0 (current) Parsed [ 0.059s] (current) Building datafusion-ffi v54.1.0 (baseline) Built [ 61.614s] (baseline) Parsing datafusion-ffi v54.1.0 (baseline) Parsed [ 0.063s] (baseline) Checking datafusion-ffi v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.238s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 127.539s] datafusion-ffi Building datafusion-functions v54.1.0 (current) Built [ 31.332s] (current) Parsing datafusion-functions v54.1.0 (current) Parsed [ 0.085s] (current) Building datafusion-functions v54.1.0 (baseline) Built [ 31.495s] (baseline) Parsing datafusion-functions v54.1.0 (baseline) Parsed [ 0.087s] (baseline) Checking datafusion-functions v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.396s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 64.615s] datafusion-functions Building datafusion-physical-expr v54.1.0 (current) Built [ 30.065s] (current) Parsing datafusion-physical-expr v54.1.0 (current) Parsed [ 0.047s] (current) Building datafusion-physical-expr v54.1.0 (baseline) Built [ 30.070s] (baseline) Parsing datafusion-physical-expr v54.1.0 (baseline) Parsed [ 0.049s] (baseline) Checking datafusion-physical-expr v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.437s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 61.601s] datafusion-physical-expr ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
