buraksenn commented on PR #23804: URL: https://github.com/apache/datafusion/pull/23804#issuecomment-5048357186
> Thanks for this fix; overall looks reasonable to me. > > As far as I can tell, there are no longer any expressions for which `preserves_lex_ordering` will return true. Do we think this API is still useful? Can we come up with any use-cases where either > > 1. we might add support for it in the future, or > 2. where extensions would want support for it? > > If we can't, we might consider deprecating and removing it. > > If we keep it, I'm a bit nervous doing so with no actual implementations / test coverage in-tree... I thought maybe a downstream would depend on it so did not think of removing it but I understand it can be deprecated if its not usable. I'll check other comments thanks for the review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
