kosiew commented on code in PR #23063:
URL: https://github.com/apache/datafusion/pull/23063#discussion_r3636937070
##########
datafusion/expr/src/expr.rs:
##########
@@ -930,21 +930,32 @@ pub struct ScalarFunction {
pub func: Arc<crate::ScalarUDF>,
/// List of expressions to feed to the functions as arguments
pub args: Vec<Expr>,
+ /// Original source code location, if known
+ pub spans: Spans,
Review Comment:
Between the two options you mentioned, I'd lean toward keeping the
parser-only span information out of these public struct layouts. Validating in
SqlToRel, where the call-site span is already available, seems like a good fit
and avoids introducing a semver break while still preserving the improved
diagnostics. If there's another semver-compatible way to associate the span
with these expressions, that would also work, but I don't think adding the new
public fields is something we should ship in a patch release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
