lyne7-sc commented on code in PR #23489:
URL: https://github.com/apache/datafusion/pull/23489#discussion_r3638359194
##########
datafusion/physical-plan/src/aggregates/mod.rs:
##########
@@ -3591,6 +3591,87 @@ mod tests {
Ok(())
}
+ #[tokio::test]
+ async fn partial_hash_skip_aggregation_uses_required_convert_to_state() ->
Result<()>
Review Comment:
Ah, thanks for pointing this out. I missed
`test_partial_hash_stream_skip_aggregation_after_first_batch`. It already
provides very similar coverage of the skip-partial path, so I’ve removed the
redundant test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
