neilconway commented on code in PR #23775:
URL: https://github.com/apache/datafusion/pull/23775#discussion_r3638988089
##########
datafusion/functions-nested/src/extract.rs:
##########
@@ -970,7 +970,7 @@ where
#[user_doc(
doc_section(label = "Array Functions"),
- description = "Returns the first non-null element in the array.",
+ description = "Returns the first non-null element in the array. Returns
NULL if the array is empty or all elements are NULL.",
Review Comment:
One more minor nit:
```suggestion
description = "Returns the first non-null element in the array. Returns
NULL if the array is empty or NULL.",
```
i.e., if first or more elements of the array is NULL, we'd expect a NULL
return value; we only need to document the corner-case behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
